> On Jan. 29, 2015, 5:54 p.m., kturner wrote: > > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java, line > > 3347 > > <https://reviews.apache.org/r/30417/diff/1/?file=840136#file840136line3347> > > > > While trying apply this patch to 1.5 I noticed that 1.5 is different. > > 1.5 does not keep a reference to what `Trace.on()` returns. > > > > If this reference does not need to be kept, then the fix may be > > simpler. Eric do you know if we need to keep the reference, or can we just > > call `curr.stop()` later insread of `span.stop()`.
They should be equivalent. - Eric ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30417/#review70234 ----------------------------------------------------------- On Jan. 29, 2015, 3:59 p.m., kturner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30417/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2015, 3:59 p.m.) > > > Review request for accumulo and Eric Newton. > > > Bugs: ACCUMULO-3462 and ACCUMULO-3541 > https://issues.apache.org/jira/browse/ACCUMULO-3462 > https://issues.apache.org/jira/browse/ACCUMULO-3541 > > > Repository: accumulo > > > Description > ------- > > Fixes compaction logging bug and bug with compaction state not being reset. > Patch builds on work already committed for ACCUMULO-3462. > > I am slightly nervous about the changes w/ control flow, but I feel this is > the best solution to avoid duplicate logging. > > > Diffs > ----- > > server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java > 7420ec4 > > Diff: https://reviews.apache.org/r/30417/diff/ > > > Testing > ------- > > Still running ITs. Getting this patch out for review so we can move forward > for 1.6.2. > > > Thanks, > > kturner > >
