-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30470/#review70454
-----------------------------------------------------------



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/30470/#comment115650>

    A real message about what the code was tryign to do would be nice. For 
example, a table is dropped before we try to clear the cache. A good message 
could inform the user that it's probably OK to ignore.
    
    "Error clearing tablet locator cache, will continue" or something.



server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
<https://reviews.apache.org/r/30470/#comment115648>

    Might be worthwhile to add some jitter (maybe +/- a few minutes?). I'm not 
sure noticable it would be if all tservers dropped their caches at the same 
time and then started bashing on metadata and root.


- Josh Elser


On Jan. 30, 2015, 11:41 p.m., Eric Newton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30470/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 11:41 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> ACCUMULO-3549
> 
> 
> Diffs
> -----
> 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java 
> dfec999 
> 
> Diff: https://reviews.apache.org/r/30470/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Newton
> 
>

Reply via email to