Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/29#discussion_r28789378
--- Diff:
minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloConfig.java
---
@@ -108,6 +108,19 @@ public MiniAccumuloConfig setZooKeeperStartupTime(long
zooKeeperStartupTime) {
}
/**
+ * Configure an existing ZooKeeper instance to use. Calling this method
is optional. If not set, a new ZooKeeper instance is created.
+ *
+ * @param existingZooKeepers
+ * Connection string for a already-running ZooKeeper instance
+ *
+ * @since 1.7.0
+ */
+ public MiniAccumuloConfig setExistingZooKeepers(String
existingZooKeepers) {
--- End diff --
> MiniAccumuloConfig is leaked via a public constructor and the getConfig
method on MiniAccumuloCluster
Yup, that's by design.
> If MiniAccumuloConfig doesn't have a setter for the existing zookeepers,
then it can't be used by an integration test or in general.
Right, it would need to be used via `MiniAccumuloConfigImpl` and
`MiniAccumuloClusterImpl`. We already have many methods hidden on the impl that
are not exposed in via the non-impl variants. Nearly all of our ITs in Accumulo
use the impl variants already IIRC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
