Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/56#discussion_r46318262
--- Diff:
server/base/src/main/java/org/apache/accumulo/server/util/RpcWrapper.java ---
@@ -36,20 +42,51 @@
* @since 1.6.1
*/
public class RpcWrapper {
+ private static final Logger log =
LoggerFactory.getLogger(RpcWrapper.class);
+
+ public static <T> T service(final T instance,
@SuppressWarnings("rawtypes") final Map<String,ProcessFunction<T,? extends
TBase>> processorView) {
+ // Get a handle on the isOnewayMethod and make it accessible
+ final Method isOnewayMethod;
+ try {
+ isOnewayMethod = ProcessFunction.class.getDeclaredMethod("isOneway");
+ } catch (NoSuchMethodException e) {
+ throw new RuntimeException("Could not access isOneway method", e);
+ } catch (SecurityException e) {
+ throw new RuntimeException("Could not access isOneway method", e);
+ }
+ isOnewayMethod.setAccessible(true);
+
+ final Set<String> onewayMethods = new HashSet<String>();
+ for (@SuppressWarnings("rawtypes") Entry<String,ProcessFunction<T,?
extends TBase>> entry : processorView.entrySet()) {
+ try {
+ if ((Boolean) isOnewayMethod.invoke(entry.getValue())) {
+ onewayMethods.add(entry.getKey());
+ }
+ } catch (Exception e) {
+ throw new RuntimeException(e);
+ }
+ }
+ log.debug("Found oneway Thrift methods: " + onewayMethods);
- public static <T> T service(final T instance) {
InvocationHandler handler = new
RpcServerInvocationHandler<T>(instance) {
private final Logger log =
LoggerFactory.getLogger(instance.getClass());
@Override
public Object invoke(Object obj, Method method, Object[] args)
throws Throwable {
+ // e.g. ThriftClientHandler.flush(TInfo, TCredentials, ...)
try {
return super.invoke(obj, method, args);
} catch (RuntimeException e) {
+ if (onewayMethods.contains(method.getName())) {
--- End diff --
actually that would not be a sufficient sanity check because only one way
methods are added to the set...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
