Github user keith-turner commented on the pull request:
https://github.com/apache/accumulo/pull/75#issuecomment-189385925
> The set of mutations is still global,
OIC. Your right, its not as bad as I thought. Although there is still
problem. With the per thread mutation writers, mutations bound for the same
tserver may never be merged in some cases. This situations are less likely to
occur though. I am thinking of something like the following.
* Thread 1 bins 1000 mutations for 20 tservers
* 3 tserver queues are processed by send threads
* Thread 2 bins 1000 mutations for 20 tserver (at this point 17 tservers
from the 1st binning are not processed by send threads, those mutations are not
merged together).
This makes me wonder, why have a mutation writer per thread? Why not just
add to the mutation writer outside of the sync?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---