Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/75#discussion_r54311365
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
@@ -699,7 +701,16 @@ else if (Tables.getTableState(context.getInstance(),
table) == TableState.OFFLIN
}
- void addMutations(MutationSet mutationsToSend) {
+ void queueMutations(final MutationSet mutationsToSend) {
+ queueThreadPool.submit(new Runnable() {
--- End diff --
Ultimately, I really don't have that strong of an opinion here. I think
using the ExecutorService as a queue for MutationSets is a smell (instead of
directly maintaining such a queue), but I can understand the argument for using
the ExecutorService *because* it encompasses both approaches. I don't think
there's a big reason one way or the other; I simply think that the pseudo-code
outline above is clearer than Dave's current changes. If Keith and Dave are
happy, then merge it and move on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
