Github user dlmarion commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/75#discussion_r54321264
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
@@ -638,6 +648,21 @@ public MutationWriter(int numSendThreads) {
queued = new HashSet<String>();
sendThreadPool = new SimpleThreadPool(numSendThreads,
this.getClass().getName());
locators = new HashMap<String,TabletLocator>();
+ binTimer.schedule(new TimerTask() {
+ @Override
+ public void run() {
+ MutationSet m = queue.poll();
+ while (null != m) {
+ try {
+ addMutations(m);
+ } catch (Exception e) {
+ updateUnknownErrors("Error processing mutation set", e);
+ }
+ m = queue.poll();
+ }
+ }
+ }, 0, 500);
--- End diff --
Well, in the previous revision I was adding a MutationSet to an
ExecutorService that had an unbounded queue and 1 thread. That's not immediate.
Can MutationSets be binned concurrently? If so, then I can change the timer
from a fixed delay to fixed rate. Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
