Github user joshelser commented on the pull request:
https://github.com/apache/accumulo/pull/94#issuecomment-210545040
> For me, ShellServerIT.trace() always fails. I've been banging my head
against this for the past 3 days, trying to get tests to succeed while working
on ACCUMULO-4187. I'll take your word that it doesn't fail for everyone all the
time. With this change, ShellServerIT has succeeded for me the 5 or 6 times
I've run it.
Sorry about this. @billierinaldi had pointed out to me that she thinks
ACCUMULO-1755 had broken this. I didn't know that this one was broken. If our
tests are not reliably passing, that's wrong/bad. Give us a shout before
bashing your head next time :)
> Race conditions are notably difficult to diagnose.
Yep, that's why I asked :).
> I can think of a few ways one might better expose this particular bug
under lab conditions, but any such test would by necessity be timing sensitive,
and I do so hate knowingly writing timing-sensitive tests.
Yep, totally not asking you to do so. I was looking for some understanding
that you 1. put thought into whether or not this is directly test-able and 2.
you had a plausible idea of why this was sometimes happening. Sounds fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
