Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/138#discussion_r74798224
  
    --- Diff: assemble/bin/start-daemon.sh ---
    @@ -103,6 +103,9 @@ if [[ "$SERVICE" != "tserver" || $NUM_TSERVERS -eq 1 
]]; then
        fi
        echo "Starting $SERVICE on $HOST"
     
    +   OUTFILE="${ACCUMULO_LOG_DIR}/${SERVICE}_1_${LOGHOST}.out"
    --- End diff --
    
    I think we can just bring the entire OUTFILE/ERRFILE definition and 
`rotate_log` call into the if-branch like you did for the else-branch, and 
remove the original declaration.
    
    Although, I wonder why we even need to two branches? Didn't this problem 
come about because we weren't using the same logic? If we hit the "start 
multiple tservers" branch and only start 1 tserver, would it do what we want?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to