Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/143#discussion_r77050370
--- Diff:
test/src/test/java/org/apache/accumulo/test/functional/GarbageCollectorIT.java
---
@@ -139,6 +150,52 @@ public void gcTest() throws Exception {
}
@Test
+ public void gcDeleteDeadTServerWAL() throws Exception {
+ // Kill GC process
+ killMacGc();
+
+ // Create table and ingest data
+ Connector c = getConnector();
+ c.tableOperations().create("test_ingest");
+ c.tableOperations().setProperty("test_ingest",
Property.TABLE_SPLIT_THRESHOLD.getKey(), "5K");
+ String tableId =
getConnector().tableOperations().tableIdMap().get("test_ingest");
+ TestIngest.Opts opts = new TestIngest.Opts();
+ VerifyIngest.Opts vopts = new VerifyIngest.Opts();
+ vopts.rows = opts.rows = 10000;
+ vopts.cols = opts.cols = 1;
+ opts.setPrincipal("root");
+ vopts.setPrincipal("root");
+ TestIngest.ingest(c, opts, new BatchWriterOpts());
+
+ // Test WAL log has been created
+ List<String> walsBefore = getWALsForTableId(tableId);
+ Assert.assertEquals("Should be one WAL", 1, walsBefore.size());
+
+ // Flush and check for no WAL logs
+ c.tableOperations().flush("test_ingest", null, null, true);
--- End diff --
Actually, this logic isn't going to work. A server could be hosting
metadata which will have a WAL to make the metadata updates durable. But, I
don't think this check is necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
