Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/134#discussion_r77682007
--- Diff:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
@@ -93,15 +89,18 @@ public int read(final byte[] b, final int off, int len)
throws IOException {
if (n == 0)
return -1;
Integer ret = 0;
- final FSDataInputStream inLocal = in;
--- End diff --
Is there a reason that the class member `in` can't be marked as `final`? If
we're synchronizing on it, that's a good compile-time check to verify that we
don't accidentally start synchronizing on different objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
