Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/221#discussion_r102989431
  
    --- Diff: assemble/conf/log4j-service.properties ---
    @@ -15,42 +15,48 @@
     
    --- End diff --
    
    Would it make sense to add some comments about this files intended use by 
Accumulo?
    
    Also, it may be helpful to mention that these are log4j 1.2.X config files, 
to help users find the appropriate documentation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to