Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/227#discussion_r104201693
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/NativeMap.java ---
@@ -70,11 +70,10 @@
static {
// Check standard directories
List<File> directories = new ArrayList<>(Arrays.asList(new File[] {new
File("/usr/lib64"), new File("/usr/lib")}));
- // Check in ACCUMULO_HOME location, too
- String accumuloHome = System.getenv("ACCUMULO_HOME");
- if (accumuloHome != null) {
- directories.add(new File(accumuloHome + "/lib/native"));
- directories.add(new File(accumuloHome + "/lib/native/map")); // old
location, just in case somebody puts it here
--- End diff --
I think checking for the property, then checking for the ACCUMULO_HOME,
then checking doing something in the absence of either of them... at some
point, the number of layers makes it hard to grok and is no longer "simple".
If we want simplicity, a better way is to provide good defaults that are
easily modified in the configs, rather than trying to handle a bunch of various
conditions in code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
