Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/224#discussion_r106905869
--- Diff:
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java ---
@@ -1812,7 +1884,26 @@ public TSummaries getSummariesFromFiles(TInfo tinfo,
TCredentials credentials, T
BlockCache summaryCache = resourceManager.getSummaryCache();
BlockCache indexCache = resourceManager.getIndexCache();
FileSystemResolver volMgr = p ->
fs.getVolumeByPath(p).getFileSystem();
- return new Gatherer(TabletServer.this, request,
tableCfg).processFiles(volMgr, files, summaryCache, indexCache, srp).toThrift();
+ Future<SummaryCollection> future = new Gatherer(TabletServer.this,
request, tableCfg).processFiles(volMgr, files, summaryCache, indexCache, srp);
+
+ return startSummaryOperation(credentials, future);
+ }
+
+ @Override
+ public TSummaries contiuneGetSummaries(TInfo tinfo, long sessionId)
throws NoSuchScanIDException, TException {
+ SummarySession session = (SummarySession)
sessionManager.getSession(sessionId);
+ if (session == null) {
+ throw new NoSuchScanIDException();
--- End diff --
That exception is used in a few other places (that are not scan) to
indicate no such session id. I was just following that. The exception should
be named no such session exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
