Github user keith-turner commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/244#discussion_r112786051
--- Diff:
core/src/main/java/org/apache/accumulo/core/iterators/WrappingIterator.java ---
@@ -58,21 +58,21 @@ protected void
setSource(SortedKeyValueIterator<Key,Value> source) {
public Key getTopKey() {
if (seenSeek == false)
throw new IllegalStateException("never been seeked");
- return getSource().getTopKey();
+ return source.getTopKey();
--- End diff --
I experimented with making the VersioningIterator and Filter not call
WrappingIterator.getSource() multiple times in their loops. I saw a noticeable
difference, like 5% increase for the VersioningIterator. I change the code to
call getSource() once before the loop and store the source in a local var.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
