Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/254#discussion_r114387450
  
    --- Diff: 
server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
 ---
    @@ -416,6 +444,12 @@ protected Status replicateLogs(ClientContext 
peerContext, final HostAndPort peer
         Status lastStatus = status, currentStatus = status;
         final AtomicReference<Exception> exceptionRef = new 
AtomicReference<>();
         while (true) {
    +      // Check if the thread has been interrupted prior to replicating data
    +      if (Thread.interrupted()) {
    --- End diff --
    
    I can't be sure if its needed.  Its a question of do all of the functions 
called by this code handle interrupts properly? I have no idea what the answer 
to that question is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to