Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/254#discussion_r114616296
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/Property.java ---
    @@ -584,6 +584,8 @@
       REPLICATION_WORK_PROCESSOR_PERIOD("replication.work.processor.period", 
"0s", PropertyType.TIMEDURATION,
           "Amount of time to wait before re-checking for replication work, not 
useful outside of tests"),
       REPLICATION_TRACE_PERCENT("replication.trace.percent", "0.1", 
PropertyType.FRACTION, "The sampling percentage to use for replication traces"),
    +  REPLICATION_RPC_TIMEOUT("replication.rpc.timeout", "2m", 
PropertyType.TIMEDURATION,
    --- End diff --
    
    If this is done for 1.7, then it's a behavior change in replication for a 
bug fix release.   I think its ok and good, we somehow need to remember to 
mention this in the 1.7 release notes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to