Github user matthpeterson commented on the issue:

    https://github.com/apache/accumulo/pull/269
  
    RE: Formatting comments
    Agreed, the formatting is jarring as-is.  Does the below format look better 
to everyone?  I've added an "Index Entries" header, put the index of the 
IndexEntry on the left (double indented) and the IndexEntry information on the 
right, indented to line up with the other values in the print out.  
    
    I'd prefer to get consensus before changing the formatting so please let me 
know if you would like something other than what I've proposed below.  I'll try 
to make the code changes tomorrow.
    
    ```
    Locality group           : <DEFAULT>
        Num   blocks           : 1
        Index level 0          : 29 bytes  1 blocks
        First key              : r1 f1:q1 [] 1497902390579 false
        Last key               : r1 f1:q5 [] 1497902395419 false
        Index Entries
                0              : Key: r1 f1:q5 [] 1497902395419 false 
NumEntries: 4 Offset: 16 CompressedSize: 53 RawSize: 66
                1              : Key: r2 f1:q5 [] 1497902395419 false 
NumEntries: 4 Offset: 16 CompressedSize: 53 RawSize: 66
        Num entries            : 4
        Column families        : [f1]I can add the indenting.
    ```
    
    RE: printing multiple levels
    I was interested in getting only the lowest level of the index for this 
ticket so that I could get some statistics on the rfile contents without 
reading the entire file.  Having multiple indexes might simplify certain types 
of analysis and complicate others.  It would be nice to be able to easily 
filter the lowest level.  Perhaps the level could be printed on the left hand 
side, like this: 
    ```
        Index Entries
                L0,0              : Key: r1 f1:q5 [] 1497902395419 false 
NumEntries: 4 Offset: 16 CompressedSize: 53 RawSize: 66
                L0,1              : Key: r2 f1:q5 [] 1497902395419 false 
NumEntries: 4 Offset: 16 CompressedSize: 53 RawSize: 66
    ```
    
    Overall it seems worthwhile though to provide more information.  I'd 
welcome Keith's offer of posting a function.  Feel free to adjust the PR with 
the suggested code if you'd like or I can modify it.  
    
    Thanks for the feedback.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to