Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/273#discussion_r124141590
--- Diff:
core/src/main/java/org/apache/accumulo/core/client/security/tokens/KerberosToken.java
---
@@ -51,11 +52,11 @@
* The user that is logged in
*/
public KerberosToken(String principal) throws IOException {
- requireNonNull(principal);
+ this.principal = requireNonNull(principal);
final UserGroupInformation ugi = UserGroupInformation.getCurrentUser();
- checkArgument(ugi.hasKerberosCredentials(), "Subject is not logged in
via Kerberos");
- checkArgument(principal.equals(ugi.getUserName()), "Provided principal
does not match currently logged-in user");
- this.principal = ugi.getUserName();
+ if (AuthenticationMethod.KERBEROS == ugi.getAuthenticationMethod()) {
+ checkArgument(ugi.hasKerberosCredentials(), "Subject is not logged
in via Kerberos");
+ }
--- End diff --
I think this check is backwards. We should exclude the check when it
doesn't apply (`AuthenticationMethod.PROXY`?), rather than include the check
when it does. Right now, this allows even `AuthenticationMethod.SIMPLE` to also
construct a valid `KerberosToken`, and that's clearly incorrect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
