Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126758739
  
    --- Diff: 
core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java ---
    @@ -0,0 +1,42 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +
    +import org.apache.accumulo.core.client.Instance;
    +
    +public class Namespace {
    --- End diff --
    
    Thanks for the context, you two.
    
    I'm reticent to include structure on the promise of "code getting finished" 
as this is all internal anyways. Without the new public API codebase being 
anywhere close to inclusion, this just seems like a layer of indirection that 
causes more typing. At the same time, I can't think of a reason that it's 
harmful -- it doesn't make sense to me to introduce these classes without any 
immediate benefit/gain.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to