Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/275#discussion_r128386621
--- Diff:
core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java ---
@@ -50,16 +52,16 @@
// private static final Logger log =
Logger.getLogger(ColumnFamilySet.class);
- public static final Set<ByteSequence> EMPTY_CF_SET =
Collections.emptySet();
+ public static final Set<ByteSequence> EMPTY_CF_SET = ImmutableSet.of();
--- End diff --
Oh, like the reference check against `this`? I could see that being
beneficial.
A comment in the code as to use for ImmutableSet for that reason would be
quite appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
