Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/253#discussion_r129967127
  
    --- Diff: 
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java ---
    @@ -28,5 +29,5 @@
      * benefit from using per-table configuration using {@link 
Property#TABLE_ARBITRARY_PROP_PREFIX}.
      */
     public interface VolumeChooser {
    -  String choose(VolumeChooserEnvironment env, String[] options);
    +  String choose(VolumeChooserEnvironment env, String[] options) throws 
AccumuloException;
    --- End diff --
    
    I could, but I think allowing one to throw accumulo exceptions is 
reasonable   Implementers do not need to include a throws clause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to