Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/292#discussion_r133536502
--- Diff:
server/master/src/main/java/org/apache/accumulo/master/tableOps/Utils.java ---
@@ -59,21 +57,16 @@ static void checkTableDoesNotExist(Instance instance,
String tableName, Table.ID
throw new AcceptableThriftTableOperationException(null, tableName,
operation, TableOperationExceptionType.EXISTS, null);
}
- static <T extends AbstractId> T getNextTableId(String tableName,
Instance instance, Class<T> idClassType) throws
AcceptableThriftTableOperationException {
+ static String getNextTableId(String tableName, Instance instance) throws
AcceptableThriftTableOperationException {
--- End diff --
It's not different, but it prevents passing a String around (which I
believe was the original reason you added the reflection code), but without
reflection (lambdas are faster). It's up to you. I like the elegance of the
functional stuff, but I don't think it matters much, as long as we're avoiding
reflection.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
