My impression is that the metrics names are a big pain point already, and that they appear differently, depending on which Hadoop Metrics 2 sink the user has configured, and what happens to them after that (InfluxDB naming conventions seems to be a problem sometimes while using fluo-uno). Since the names are not public API, we should be able to change them easily, but the changes may still cause users headaches.
My thoughts are that it's probably worth causing the disruption, if we can get to a better place to keep the names stable, intuitive, and useful with better naming conventions, but that it would be good to try to document the new names very clearly, so it's easy for people to use the new metrics in place of whatever is removed. I would prefer we work to establish a good naming convention from scratch, than to try to do anything to preserve previous naming compatibility. On Tue, Sep 21, 2021 at 3:45 PM Dave Marion <[email protected]> wrote: > > There is a WIP pull request against 2.1.0-SNAPSHOT for replacing the Hadoop > Metrics2 framework with Micrometer[1]. Micrometer suggests using a naming > pattern[2] for the metrics internally where words are all lowercase > separated by a period. Micrometer output formats then rewrite the metric > names to the destination specific format. It's possible that we may not be > able to produce metrics in the same exact way as the Hadoop Metrics2 > framework. Metrics are not part of the public API, but we do want to try > and retain as much backwards compatibility as possible. In the event that > we cannot get that compatibility it has been suggested that we document how > things are different. As I have limited knowledge of how the metrics are > being used today, I'm looking for some feedback from the community as to > how painful it would be if metric names changed in a minor release. > > [1] https://micrometer.io/ > [2] https://micrometer.io/docs/concepts#_naming_meters
