Hi Dan, Auto-publishing a PR to a staging branch is probably not a good idea (I can see how it could be abused to put malicious content on the apache.org domain).
Having some on-demand staging that is manually triggered could work, but I'm pretty sure that would lead to more complexity than what we have now, and right now it's very minimal. I'm not sure if this helps, but I've already implemented auto-building each PR, which you could view locally if you want. Check the https://github.com/apache/accumulo-website/actions for recently built site artifacts from PRs. Maybe that is a good option for some people that would make this proposed streamlining easier to accept? On Fri, Apr 7, 2023 at 7:39 PM Daniel Roberts <ddani...@gmail.com> wrote: > > +1 I definitely agree that merges to main should deploy to asf-site. > However, I think staging still has a place in the build pipeline, just not > where it currently lives. > > The staging branch provides a way to review rendered changes and does > remove the "worked on my machine" factor. > Reviews can cover both the markdown source and rendered code. > > So, could auto publishing to the staging branch be part of the QA build > step? Or maybe a manual build step being triggered? > I could see the latter being useful if multiple PRs were open at the same > time to avoid artifact publishing collisions. > > On Fri, Apr 7, 2023 at 6:34 PM Christopher Shannon < > christopher.l.shan...@gmail.com> wrote: > > > +1 to make the change. I agree that when PRs are merged we generally just > > want to publish immediately. > > > > FWIW, this is how we do things for the ActiveMQ website > > <https://github.com/apache/activemq-website> and it works fine, we just > > publish and there is no staging. > > > > On Fri, Apr 7, 2023 at 3:49 PM Christopher <ctubb...@apache.org> wrote: > > > > > Hi Accumulo Devs, > > > > > > When I first set up the automation using .asf.yaml for Jekyll builds > > > to go to the asf-staging branch, I expected us to get a bit more use > > > out of the staging site at https://accumulo.staged.apache.org/ > > > However, that really hasn't happened, and it seems that we basically > > > almost always want to publish to the https://accumulo.apache.org once > > > we've approved a PR against the main branch and have a successful > > > Jekyll build. > > > Having the staging site is now just an unnecessary extra step to > > > publish (that we sometimes forget to do for a while, even though it's > > > trivial to run ./_scripts/publish.sh). I'm not sure it's adding any > > > value. > > > > > > Perhaps we should just have Jekyll build directly to the asf-site > > > branch and get rid of the asf-staging branch? > > > > > > The one benefit to the staging site is that, in theory, it's a > > > conscientious decision to publish. But, I don't think we've ever come > > > across any kind of situation where we wanted to stage the site, but > > > then didn't immediately want to publish it. So, I'm not convinced that > > > extra step is adding any value, especially since we're almost always > > > making the conscientious decision in GitHub when approving a PR to > > > update the site already. > > > > > > Any thoughts or opinions on this? I'm leaning slightly towards > > > streamlining this. > > > > > > Regards, > > > Christopher > > > > >
