ctubbsii commented on code in PR #2: URL: https://github.com/apache/accumulo-access/pull/2#discussion_r1319803810
########## .asf.yaml: ########## @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features + +github: + description: "Apache Accumulo Access Control Library" + homepage: https://accumulo.apache.org + labels: + - accumulo + - big-data + - hacktoberfest + features: + wiki: false + issues: true + projects: false Review Comment: It's useful to use projects. In the main repo, we use projects to track milestones for multiple versions still being developed (since GitHub doesn't support tagging multiple milestones). We probably won't use that here... we can keep one linear set of releases and just use the normal milestone feature. However, we also use projects for other things, and that might end up being useful in this repo as well. I would go ahead and enable it since it's not hurting anything to have it enabled and there's a good chance we'll end up using it. ```suggestion projects: true ``` ########## .asf.yaml: ########## @@ -0,0 +1,39 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +# https://cwiki.apache.org/confluence/display/INFRA/git+-+.asf.yaml+features + +github: + description: "Apache Accumulo Access Control Library" + homepage: https://accumulo.apache.org + labels: + - accumulo + - big-data + - hacktoberfest + features: + wiki: false + issues: true + projects: false + +notifications: + commits: comm...@accumulo.apache.org + issues: notificati...@accumulo.apache.org + pullrequests: notificati...@accumulo.apache.org + jobs: notificati...@accumulo.apache.org + discussions: notificati...@accumulo.apache.org Review Comment: The job notifications could get a little spammy, and I don't think they are particularly useful in the mailing list archive. I would suggest dropping that. Unlike some of the others, I don't think it defaults to dev@... it just doesn't get used at all. The discussions feature isn't enabled, so that setting is pointless to set... it's just using up space. I'd drop that to minimize the file and reduce confusion of what effect is it having. ```suggestion ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
