[
https://issues.apache.org/activemq/browse/AMQCPP-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_39485
]
Albert Strasheim commented on AMQCPP-93:
----------------------------------------
Your patch doesn't break any unit or integration tests, so it looks good.
GCC 4.1.1 emits the following warning though:
activemq/io/DataInputStream.cpp: In member function 'virtual std::string
activemq::io::DataInputStream::readString()':
activemq/io/DataInputStream.cpp:236: warning: comparison between signed and
unsigned integer expressions
I'm not certain, but I think the right way to fix this is to cast
sizeof(tmpStr) to std::ptrdiff_t before comparing it p - tmpStr.
> Performance analysis
> --------------------
>
> Key: AMQCPP-93
> URL: https://issues.apache.org/activemq/browse/AMQCPP-93
> Project: ActiveMQ C++ Client
> Issue Type: Task
> Affects Versions: 2.0
> Reporter: Nathan Mittler
> Assignee: Nathan Mittler
> Fix For: 2.2
>
> Attachments: amqcpp-perf1.patch, amqcpp-perf1v2.patch, bench1.cpp,
> DataInputStream.patch, patch Results.xls
>
>
> Do a performance analysis on openwire vs stomp.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
