[ 
https://issues.apache.org/activemq/browse/AMQ-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41895#action_41895
 ] 

David Jencks commented on AMQ-1489:
-----------------------------------

I'm no expert in how this is supposed to work, but the comment in the trunk 
code makes me wonder if the patch is correct.

Without the patch, a URI with ?discoveryURI=foo will result in setting the 
discoveryURI and other URIs will use the default.

With the patch, IIUC, the default will never be used.

> discoveryUri in transportConnector and uri in networkConnector partially 
> ignored if multicast
> ---------------------------------------------------------------------------------------------
>
>                 Key: AMQ-1489
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1489
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Connector
>    Affects Versions: 4.1.1
>            Reporter: Gerald Loeffler
>            Assignee: David Jencks
>             Fix For: 4.1.2
>
>
> This bug relates to the MulticastDiscoveryAgent and was discovered when 
> 1. the discoveryUri of a transportConnector is a multicast-uri such as
> {code:xml}
> <transportConnector uri="..." discoveryUri="multicast://239.3.7.0:37000" />
> {code}
> or
> 2. the uri of a networkConnector is a multicast-uri such as
> {code:xml}
> <networkConnector name="..." uri="multicast://239.3.7.0:37000">
> {code}
> In these cases, the uri is partially ignored by the MulticastDiscoveryAgent: 
> the host-name of the uri (239.3.7.0) is extracted and used as the group name 
> by the MulticastDiscoveryAgent. But the actual multicast group IP is always 
> 239.255.2.3 and the multicast port is always 6155, regardless of what the 
> actual uri is in the configuration.
> The reason for this is that MulticastDiscoveryAgentFactory creates a new 
> MulticastDiscoveryAgent and sets the group based on the uri's host, but fails 
> to set the discoveryURI itself. MulticastDiscoveryAgentFactory should be 
> corrected to do this:
> {code:java}
> MulticastDiscoveryAgent rc = new MulticastDiscoveryAgent();
> rc.setDiscoveryURI(uri); // missing
> rc.setGroup(uri.getHost());
> {code}
> Without the above setting of the discoveryURI the MulticastDiscoveryAgent 
> always uses the DEFAULT_DISCOVERY_URI_STRING which is 
> "multicast://239.255.2.3:6155", explaining the erroneous behaviour described 
> above.
>   kind regards,
>   gerald
> http://www.gerald-loeffler.net

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to