[
https://issues.apache.org/activemq/browse/AMQ-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Tully resolved AMQ-2892.
-----------------------------
Fix Version/s: 5.4.1
Resolution: Fixed
applied suggestion in r991536 - thanks.
> ServerSessionImpl in module ra does not report exception with stacktrace
> ------------------------------------------------------------------------
>
> Key: AMQ-2892
> URL: https://issues.apache.org/activemq/browse/AMQ-2892
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 5.4.0
> Environment: Mac OX 10.6
> Reporter: Benoit Xhenseval
> Assignee: Gary Tully
> Priority: Minor
> Fix For: 5.4.1
>
>
> The ServerSessionImpl code does not report errors correctly (i.e. never shows
> the stacktrace):
> in the run() method, the catch is like this:
> {code:title=ServerSessionImpl.java|borderStyle=solid}
> } catch (Throwable e) {
> stale = true;
> if ( log.isInfoEnabled() ) {
> log.info("Endpoint failed to process message. Reason: " +
> e.getMessage());
> } else if ( log.isDebugEnabled() ) {
> log.debug("Endpoint failed to process message.", e);
> }
> {code}
>
> but this means that you will never see the actual exception...(since if DEBUG
> is enabled, INFO would usually always be, therefore only the log.info is only
> called and this does not provide the stacktrace...) the code would be better
> like this:
> {code:title=ServerSessionImpl.java|borderStyle=solid}
> } catch (Throwable e) {
> stale = true;
> if ( log.isDebugEnabled() ) {
> log.debug("Endpoint failed to process
> message.", e);
> } else if ( log.isInfoEnabled() ) {
> log.info("Endpoint failed to process message. Reason: " +
> e.getMessage());
> }
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
