[ 
https://issues.apache.org/jira/browse/AMQ-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423932#comment-13423932
 ] 

Timothy Bish commented on AMQ-3933:
-----------------------------------

>From reviewing the code and looking at what some of the sync points are I 
>don't think even with the ConcurrentLinkedQueue you can remove all the 
>syncronization as it servers to control orderly shutdown as well.  It doesn't 
>really appear that making this change would result in much improvement once 
>you account for the shutdown cases.  
                
> TransportConnection.dispatchQueue synchronized LinkedList to 
> ConcurrentLinkedQueue
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-3933
>                 URL: https://issues.apache.org/jira/browse/AMQ-3933
>             Project: ActiveMQ
>          Issue Type: Improvement
>    Affects Versions: 5.6.0
>         Environment: Linux 
>            Reporter: Martin Chan Shu Ching
>            Priority: Minor
>              Labels: newbie
>         Attachments: TestQueue.java, TransportConnectionTest.java
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> TransportConnection.dispatchQueue currently uses a synchronized LinkedList to 
> pass all objects between the broker and the transport connection to the 
> client. This isn't very efficient as the whole list is locked whenever an 
> item is added or removed. ConcurrentLinkedQueue is about 20% faster in my 
> tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to