[ https://issues.apache.org/jira/browse/AMQ-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14078453#comment-14078453 ]
Timothy Bish commented on AMQ-5294: ----------------------------------- Moved comment to the correct issue, AMQ-5294 not AMQ-5249 {quote} GitHub user jkorab opened a pull request: https://github.com/apache/activemq/pull/36 Fix for AMQ-5249 Approach to the change is described in http://issues.apache.org/jira/browse/AMQ-5294?focusedCommentId=14077910&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14077910 For some reason there is also a commit in this pull request that was already merged (Added close destroy-method...), apologies something messed up in the workflow. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jkorab/activemq trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq/pull/36.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #36 ---- commit a92027691a8de2482e43ab33ed4e9dd0f7a24377 Author: Jakub Korab <jakub.ko...@gmail.com> Date: 2014-04-03T10:36:24Z Added close destroy-method to Postgres data source. Example crashed and burned on master-slave failover when master lost network connectivity - took down VM. commit 039750805eec66fad2c273e7db5c15912acb272c Author: jkorab <jakub.ko...@gmail.com> Date: 2014-07-25T11:23:11Z Merge branch 'trunk' of https://github.com/apache/activemq into trunk commit ecedea34faee1e8c56daa4a7a9c40261cdba91fe Author: jkorab <jakub.ko...@gmail.com> Date: 2014-07-29T16:25:09Z Fix for AMQ-5294. Refactored tool to unify timing of the samplers and client (producer/consumer), in such a way that the performance test no longer sits waiting for sampler to complete, even though the run terminated much earlier. Full description of approach in http://issues.apache.org/jira/browse/AMQ-5294?focusedCommentId=14077910&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14077910 ---- {quote} > Unify client and sampler timings in activemq-perf-maven-plugin > -------------------------------------------------------------- > > Key: AMQ-5294 > URL: https://issues.apache.org/jira/browse/AMQ-5294 > Project: ActiveMQ > Issue Type: Improvement > Components: Performance Test > Affects Versions: 5.10.0 > Environment: All > Reporter: Jakub Korab > Priority: Minor > > Fundamentally there are 2 entities in the plugin managed by different > threads/threadpools: > * the client (generic term for producer of consumer) > * the samplers (throughput + cpu) > These entities can all be configured separately, and the plugin does not > complete until the slowest of these is done. Now, the problem is that > these things all have separate flags, which generally aren't overridden > unless you want to use a really long command line. For example, to get a > perf test that runs for 10 seconds, you have to do the following: > mvn activemq-perf:producer -Dproducer.sendDuration=10000 > -DtpSampler.duration=10000 -DtpSampler.rampUpTime=0 > -DtpSampler.rampDownTime=0 -DcpuSampler.duration=10000 > -DcpuSampler.rampUpTime=0 -DcpuSampler.rampDownTime=0 > And all this is before you start adding flags to do anything useful with > it. This is because: > 1. sampler threads sleep for the ramp-up time (default 30s); if this > is longer than the producer's send duration then the sampler won't > even start doing anything until |the producer has well and truly > completed > 2. the test runs until the longest configured sampler (by default both > throughput + cpu run) > So it's kind of a mess. I'd love to be able to use the principle of > least surprise (and configuration) so that you can just do this: > mvn activemq-perf:producer -Dproducer.sendDuration=10000 > mvn activemq-perf:producer -Dproducer.sendType=count > -Dproducer.sendCount=10000 -- This message was sent by Atlassian JIRA (v6.2#6252)