[
https://issues.apache.org/jira/browse/AMQ-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283004#comment-14283004
]
Eyad Ebrahim commented on AMQ-2079:
-----------------------------------
I'm not sure this is the right place, but starting from 5.10.0, that part of
code has been deleted:
if (!transacted && acknowledgeMode == Session.SESSION_TRANSACTED) {
acknowledgeMode = Session.AUTO_ACKNOWLEDGE;
}
The session is not transacted and absent an XA transaction, we are left with a
problem an exception when we try to commit the ActiveMQ session.
Was there an issue and what is the back story for it, so I can change our code
accordingly.
Thank you very much.
> conflict between checking validity of createSession args and requirement to
> ignore them in managed environment
> --------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-2079
> URL: https://issues.apache.org/jira/browse/AMQ-2079
> Project: ActiveMQ
> Issue Type: Bug
> Components: Connector
> Affects Versions: 5.3.0
> Reporter: David Jencks
> Assignee: David Jencks
> Fix For: 5.3.0
>
>
> Since amq 4 someone added some parameter checking to
> ActiveMQConnection.createSession. This seems like a good idea until you get
> to the connector and read the ejb spec where it says in a managed environment
> these parameters should be ignored. I'm not sure how much they really can be
> ignored if an xa tx is not present. What I've done is to enhance the
> checking in ActiveMQConnection.createSession to be more thorough with better
> messages and to modify the ra ManagedConnectionProxy to modify one of the
> parameters if they are inconsistent (i.e. transacted == false, but ack mode
> == SESSION_TRANSACTED) (I change it to AUTO_ACKNOWLDEDGE). I haven't found
> this causing any problems.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
