Canceling the vote based on Tim's feedback. I'll resolve these issues and send another RC very soon.

Thanks
Martyn

On 13/05/15 04:03, Clebert Suconic wrote:
The Quickstart is not yet being distributed...  We are only
distributing the user-manual at this point.
We might reactivate the quickstart at some point and we are
maintaining to not be too far away from the source reality.... so
anything on quickstart is not a blocker now.

And do you really think mentioning ActiveMQ without Artemis in certain
places is a blocker issue?


the mail list is on the website only, right?

On Tue, May 12, 2015 at 6:34 PM, Timothy Bish <tabish...@gmail.com> wrote:
-1

I checked out the source and binary distributions, built the source and
ran tests that bit looks fine.  Checked license and notice files content
which also looks good.

Two things that I think are a concern and should be addressed prior to
releasing.

* When extracting from the tar.gz file there are some funny file
permissions being used, the LICENSE and NOTICE files along with
everything in 'examples' and 'web' directory all have RWX permissions
for user, group and world.  The web folder one being the most concerning
to me. The distribution shouldn't make it easy for me to mistakenly put
something out that has files anyone can change by default.

* Looking at docs in the source distribution I see conflicting
information and references to ActiveMQ proper where I'd expect Artemis
to be used.  In the ./apache-artemis-1.0.0-src/docs/quickstart-guide/en
folder for instance:

    1. The about.md file refers solely to ActiveMQ as the project and
indicates that the project runs on any Java 6+ runtime.
    2. The installation.md tells me that ActiveMQ only runs on Java 7 or
later.
    3. The downloads.md list the
page:<http://activemq.org/downloads.html> as the place to download, I'd
guess it'd be something namespaced like Apollo had:
https://activemq.apache.org/apollo/download.html
    4. In examples.md there is output shown for maven runs that shows
project name and versions of: ActiveMQ JMS Queue Example
2.3.0.BETA-SNAPSHOT which I'd guess is leftovers from the original code
donation.

Some other minor nits:

* At least one log on start refers to ActiveMQ user guide instead of
Artemis user guide:

     11:35:23,917 WARN  [org.apache.activemq.artemis.core.server]
AMQ222007: Security risk! Apache ActiveMQ Artemis is running with the
default cluster admin user and default password. Please see the cluster
chapter in the ActiveMQ User Guide for instructions on how to change this.

* Looking around in the created broker directory I found several files
that referred directly to ActiveMQ with no Artemis name attached, some
examples './etc/artemis.profile and ./bin/artemis, while this isn't a
show-stopper it would be nice if there was a consistent application of
the project name.

* The website community page does not include information about the
newly created Issues mailing list, this should be documented so that
people know where to subscribe in order to see what is happening with
project issues.  Should provide the same set of mailing lists as the
main site does: http://activemq.apache.org/mailing-lists.html

* The source release includes a RELEASING.md and a ratReport.txt which
both seemed out of place to me as the release source archive is the end
result and wouldn't expect any future releases to be cut from that.


On 05/12/2015 11:01 AM, Martyn Taylor wrote:
Hello all.

I've cut the first release candidate of the Apache Artemis project.

This is a first release of the Artemis project with protocol support
for AMQP, STOMP, CORE, HORNETQ and OPENWIRE.

The release notes can be found here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315920&version=12328953


The binary distributions can be found here:
https://repository.apache.org/content/repositories/orgapacheactivemq-1048/org/apache/activemq/apache-artemis/1.0.0/


The source archives can be found here:
https://repository.apache.org/content/repositories/orgapacheactivemq-1048/org/apache/activemq/apache-artemis/1.0.0/


The Maven repository is here:
https://repository.apache.org/content/repositories/orgapacheactivemq-1048/


The source tag:
https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;a=tag;h=refs/tags/1.0.0


The project website for that version has been staged to:
http://people.apache.org/~martyntaylor/

The vote will remain open for 72 hours.

[ ] +1 approve the release as Apache Artemis 1.0.0
[ ] +0 no opinion
[ ] -1 disapprove (and reason why)

Here's my (non-binding) +1

Regards

Martyn


--
Tim Bish
Sr Software Engineer | RedHat Inc.
tim.b...@redhat.com | www.redhat.com
twitter: @tabish121
blog: http://timbish.blogspot.com/




Reply via email to