Github user mtaylor commented on the pull request:
https://github.com/apache/activemq-artemis/pull/8#issuecomment-108295200
Hi Howard. I realise that @clebertsuconic already mentioned this but it
looks like you are importing a lot of code from ActiveMQ. Reuse of test suites
is probably going to required for more than just OpenWire going forward. It
would be great if you could find a clean solution for this.
We should try to avoid importing code from ActiveMQ into Artemis as it will
just sit there and rot whilst the ActiveMQ code base moves forward. A neater
way to do this would be to import the test module artifact and extend the
relevant pieces. If this is not possible right now it is probably worth
implementing some extension points in the ActiveMQ code base to allow reuse of
their test suites.
A start might be to implement an Artemis broker service as @clebertsuconic
suggested.
Let's have a chat on IRC.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
