Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/590#discussion_r67966625
--- Diff: artemis-journal/pom.xml ---
@@ -15,57 +15,81 @@
limitations under the License.
-->
<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
- <modelVersion>4.0.0</modelVersion>
+ <modelVersion>4.0.0</modelVersion>
- <parent>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-pom</artifactId>
- <version>1.4.0-SNAPSHOT</version>
- </parent>
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>1.4.0-SNAPSHOT</version>
+ </parent>
- <artifactId>artemis-journal</artifactId>
- <packaging>jar</packaging>
- <name>ActiveMQ Artemis Journal</name>
+ <artifactId>artemis-journal</artifactId>
+ <packaging>jar</packaging>
+ <name>ActiveMQ Artemis Journal</name>
- <properties>
- <activemq.basedir>${project.basedir}/..</activemq.basedir>
- </properties>
+ <properties>
+ <activemq.basedir>${project.basedir}/..</activemq.basedir>
+ </properties>
- <dependencies>
- <dependency>
- <groupId>org.jboss.logging</groupId>
- <artifactId>jboss-logging-processor</artifactId>
- <scope>provided</scope>
- <optional>true</optional>
- </dependency>
+ <dependencies>
+ <dependency>
+ <groupId>org.jboss.logging</groupId>
+ <artifactId>jboss-logging-processor</artifactId>
+ <scope>provided</scope>
+ <optional>true</optional>
+ </dependency>
- <!--
- JBoss Logging
- -->
- <dependency>
- <groupId>org.jboss.logging</groupId>
- <artifactId>jboss-logging</artifactId>
- </dependency>
- <dependency>
- <groupId>org.jboss.logmanager</groupId>
- <artifactId>jboss-logmanager</artifactId>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-commons</artifactId>
- <version>${project.version}</version>
- </dependency>
- <dependency>
- <groupId>org.apache.activemq</groupId>
- <artifactId>artemis-native</artifactId>
- <version>${project.version}</version>
- </dependency>
- <!-- needed to compile the tests -->
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
-</project>
+ <!--
+ JBoss Logging
+ -->
+ <dependency>
+ <groupId>org.jboss.logging</groupId>
+ <artifactId>jboss-logging</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.jboss.logmanager</groupId>
+ <artifactId>jboss-logmanager</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-commons</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-native</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+ <!-- needed to compile the tests -->
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>net.openhft</groupId>
--- End diff --
Hi Martyn,
i'm currently trying to fix the deps issue and i've found another problem:
my "tests" are not JUnit tests that could be run like the others, but
harness benchmarks, thus in order to not invalidate the results they provides
they defined a main method to be run eventually by the dev from the IDE.
They are dev tools to measure something and not something that (in this
current form at least) could be embedded in a automatic build chain...
Hence there is no need to create different profiles that exclude these
benchs using surefire's plugin, because surefire do not recognize them anyway
as proper tests.
Considering these assumptions what do you recommend to do with them?
In this moment i've added them on the main pom with type of license and
version (with scope test but only because "bench" doesn't exist in Maven!) and
without version and licence type on pom of the journal module (with scope test).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
