Github user johnament commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/653#discussion_r71780013
--- Diff:
artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompProtocolManager.java
---
@@ -393,7 +393,8 @@ public void unsubscribe(StompConnection connection,
String subscriptionID,
String durableSubscriberName) throws Exception {
StompSession stompSession = getSession(connection);
- boolean unsubscribed = stompSession.unsubscribe(subscriptionID,
durableSubscriberName);
+ String clientID = (connection.getClientID() != null) ?
connection.getClientID() : null;
--- End diff --
null check looks redundant, its always the value of
`connection.getClientID()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
