Github user johnament commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/680#discussion_r72686371
  
    --- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/FileUtil.java 
---
    @@ -63,10 +63,15 @@ public static final boolean deleteDirectory(final File 
directory) {
                 attempts++;
              }
     
    -         for (String file : files) {
    -            File f = new File(directory, file);
    -            if (!deleteDirectory(f)) {
    -               logger.warn("Failed to clean up file: " + 
f.getAbsolutePath());
    +         if (files == null) {
    +            logger.warn("Could not list files to clean up in: " + 
directory.getAbsolutePath());
    --- End diff --
    
    should this a coded log message?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to