Github user grs commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/712#discussion_r74246549
  
    --- Diff: 
artemis-protocols/artemis-proton-plug/src/main/java/org/proton/plug/context/AbstractConnectionContext.java
 ---
    @@ -73,6 +76,8 @@ public AbstractConnectionContext(AMQPConnectionCallback 
connectionCallback,
                                         ScheduledExecutorService 
scheduledPool) {
           this.connectionCallback = connectionCallback;
           this.containerId = (containerId != null) ? containerId : 
UUID.randomUUID().toString();
    +      connectionProperties.put(Symbol.valueOf("product"), 
"apache-activemq-artemis");
    --- End diff --
    
    The version string is overrideable I believe so if you had some custom 
patched version you could indicate that. The brokers in Qpid don't make this 
value customisable, so I didn't personally think it was needed. I have no 
objection though if others have a use case for altering that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to