Github user lulf commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/726#discussion_r76062794
--- Diff:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/jgroups/JChannelManager.java
---
@@ -34,7 +34,7 @@
private static final Logger logger =
Logger.getLogger(JChannelManager.class);
- private Map<String, JChannelWrapper> channels;
--- End diff --
@clebertsuconic The intention was that multiple instances of
JChannelManager would share the same set of channels. However, I see that I
forgot to synchronize global access to this map, so this change has race
conditions.
In any case, what approach would you prefer to make wrt. making only one
channel get created across broadcast and discovery groups?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
