Github user franz1981 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1144#discussion_r108658925
--- Diff:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/ActiveMQThreadPoolExecutor.java
---
@@ -46,32 +45,70 @@
private static class ThreadPoolQueue extends
LinkedBlockingQueue<Runnable> {
private ActiveMQThreadPoolExecutor executor = null;
+ private int idleThreads = 0;
public void setExecutor(ActiveMQThreadPoolExecutor executor) {
this.executor = executor;
}
@Override
- public boolean offer(Runnable runnable) {
+ public synchronized boolean offer(Runnable runnable) {
--- End diff --
@bgutjahr Great, np to wait, after the changes I'll try to built a little
benchmark on it to look if there will be any improvements/regressions that in a
full broker test couldn't be seen :+1:
This component is used pretty everywhere so I think it could worth to be
sure of it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
