Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1295#discussion_r119039588
--- Diff:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
---
@@ -93,10 +82,10 @@
public TimedBuffer(final int size, final int timeout, final boolean
logRates) {
bufferSize = size;
- this.logRates = logRates;
-
if (logRates) {
- logRatesTimer = new Timer(true);
+ this.flushProfiler = Profiler.instrumented();
+ } else {
+ this.flushProfiler = Profiler.none();
--- End diff --
agreed this is just different styles :) , as noted in main comment I'm
happy :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
