Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1347#discussion_r123297601
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/ReplicationLargeMessageBeginMessage.java
---
@@ -44,11 +46,13 @@ public int expectedEncodeSize() {
@Override
public void encodeRest(final ActiveMQBuffer buffer) {
buffer.writeLong(messageId);
--- End diff --
I'm not sure how this is possibly working...
expectedEncodeSize is not taking this new long into consideration...
Besides this will cause versioning issues...
So, you will need to do something like this on reading...
On reading.. you will need to verify the positioning of the buffer..
against the declared size.. if there's another long coming.. otherwise it
wouldn't read it.. and use the current semantic.
this is a -1.. can you fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
