Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1358#discussion_r123484532
--- Diff:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTPublishManager.java
---
@@ -256,6 +258,7 @@ void handlePubAck(int messageId) throws Exception {
private void sendServerMessage(int messageId, CoreMessage message, int
deliveryCount, int qos) {
String address =
MQTTUtil.convertCoreAddressFilterToMQTT(message.getAddress().toString(),
session.getWildcardConfiguration());
+ boolean isRetain = message.getBooleanProperty(new
SimpleString(MQTT_MESSAGE_RETAIN_KEY));
--- End diff --
You're correct, this is protected already, and if null will already default
to false.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
