Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1602#discussion_r145959061
  
    --- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
 ---
    @@ -34,6 +34,25 @@
     import org.apache.activemq.artemis.journal.ActiveMQJournalLogger;
     
     public final class TimedBuffer {
    +
    +   /**
    +    * Property name to set the percentage of error allowed while expiring 
the flush {@code timeout} to happen:
    +    * it can assume any positive value from {@code 0} to {@link 
Integer#MAX_VALUE}.
    +    * <p>
    +    * By default it is {@link #DEFAULT_TIMEOUT_ERROR_PERCENTAGE} more than 
the configured {@code timeout}.
    +    */
    +   public static final String JOURNAL_TIMEOUT_ERROR_PROPERTY_NAME = 
"journal.timeout.error";
    --- End diff --
    
    I would remove the System.property here...
    If this doesn't make sense in the configuration.. probably it's something 
users won't need to configure.


---

Reply via email to