[GitHub] activemq-artemis pull request #1605: ARTEMIS-1476 HdrHistogram support on ve...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1605#discussion_r146618064
  
    --- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java
 ---
    @@ -54,92 +172,94 @@ public static long syncTest(File datafolder,
                                    String fileName,
                                    int maxAIO,
                                    JournalType journalType) throws Exception {
    -      SequentialFileFactory factory = newFactory(datafolder, fsync, 
journalType, blockSize * blocks, maxAIO);
    -
    +      final Supplier<? extends SyncIOCompletion> ioCallbackFactory;
    +      final Histogram writeLatencies;
    --- End diff --
    
    Should this be just in the if verbose section?


---