Github user michaelandrepearce commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/1647#discussion_r151645844
  
    --- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/openwire/management/OpenWireManagementTest.java
 ---
    @@ -55,6 +87,19 @@ public void setUp() throws Exception {
        @Override
        protected void extraServerConfig(Configuration serverConfig) {
           serverConfig.setJMXManagementEnabled(true);
    +      if (useDefault) {
    +         //don't set parameters explicitly
    +         return;
    +      }
    +      Set<TransportConfiguration> acceptorConfigs = 
serverConfig.getAcceptorConfigurations();
    +      for (TransportConfiguration tconfig : acceptorConfigs) {
    +         if ("netty".equals(tconfig.getName())) {
    +            Map<String, Object> params = tconfig.getExtraParams();
    +            params.put("supportAdvisory", supportAdvisory);
    +            params.put("suppressInternalManagementObjects", suppressJmx);
    +            System.out.println("Now use properties: " + params);
    --- End diff --
    
    @gaohoward just spotted another


---

Reply via email to