Github user pgfox commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1675#discussion_r153589625
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/view/ConsumerView.java
---
@@ -45,7 +45,7 @@ public Class getClassT() {
@Override
public JsonObjectBuilder toJson(ServerConsumer consumer) {
ServerSession session =
server.getSessionByID(consumer.getSessionID());
- JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("id",
toString(consumer.sequentialID())).add("session",
toString(session.getName())).add("clientID",
toString(session.getRemotingConnection().getClientID())).add("user",
toString(session.getUsername())).add("protocol",
toString(session.getRemotingConnection().getProtocolName())).add("queue",
toString(consumer.getQueue().getName())).add("queueType",
toString(consumer.getQueue().getRoutingType()).toLowerCase()).add("address",
toString(consumer.getQueue().getAddress().toString())).add("localAddress",
toString(session.getRemotingConnection().getTransportConnection().getLocalAddress())).add("remoteAddress",
toString(session.getRemotingConnection().getTransportConnection().getRemoteAddress())).add("creationTime",
new Date(consumer.getCreationTime()).toString());
+ JsonObjectBuilder obj = JsonLoader.createObjectBuilder().add("id",
toString(consumer.sequentialID())).add("session", (session == null ? "" :
toString(session.getName()))).add("clientID", (session == null ? "" :
toString(session.getRemotingConnection().getClientID()))).add("user", (session
== null ? "" : toString(session.getUsername()))).add("protocol", (session ==
null ? "" :
toString(session.getRemotingConnection().getProtocolName()))).add("queue",
toString(consumer.getQueue().getName())).add("queueType",
toString(consumer.getQueue().getRoutingType()).toLowerCase()).add("address",
toString(consumer.getQueue().getAddress().toString())).add("localAddress",
(session == null ? "" :
toString(session.getRemotingConnection().getTransportConnection().getLocalAddress()))).add("remoteAddress",
(session == null ? "" :
toString(session.getRemotingConnection().getTransportConnection().getRemoteAddress()))).add("creationTime",
new Date(consumer.getCreationTime()).toString());
--- End diff --
@clebertsuconic originally my thought was to get as much info as possible
for the consumer but your suggestion makes more sense as that consumer will
also be closed, so there is no real point in displaying the available data.
I will update/test and push it again
Thanks
Pat
---
