Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1688#discussion_r155674146
--- Diff:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
---
@@ -253,9 +253,12 @@ public Configuration parseMainConfig(final InputStream
input) throws Exception {
String xml = XMLUtil.readerToString(reader);
xml = XMLUtil.replaceSystemProps(xml);
Element e = XMLUtil.stringToElement(xml);
-
+ NodeList children = e.getElementsByTagName("core");
--- End diff --
Why not just get the broker.xml fully validated by the xsd using
javax.xml.validation.Validator instead of manually getting elements and
recursing.
---
