GitHub user franz1981 opened a pull request:
https://github.com/apache/activemq-artemis/pull/1760
ARTEMIS-1593 RemotingConnectionImpl leaks
FileNameKey was holding a reference to PropertiesLoader.this due to its
inner class definition, causing RemotingConnectionImpl to leak through a long
chain of dependencies rooted in a PropertiesLoader's subclass property ie
PropertiesLoaderModule::callbackHandler.
FileNameKey is turned into a inner static class to break this hidden
dependency.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1593
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1760.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1760
----
commit ca7e0a1e6fc088e17e3c907e974ef7e57db752f3
Author: Francesco Nigro <nigro.fra@...>
Date: 2018-01-09T14:12:44Z
ARTEMIS-1593 RemotingConnectionImpl leaks
FileNameKey was holding a reference to PropertiesLoader.this due to its
inner class definition, causing RemotingConnectionImpl to leak through a long
chain of dependencies rooted in a PropertiesLoader's subclass property ie
PropertiesLoaderModule::callbackHandler.
FileNameKey is turned into a inner static class to break this hidden
dependency.
----
---
