Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1757
  
    Also another thing spotted, on decoding the typed properties a duplicate of 
the buffer is made
    
    ```
    final ByteBuf byteBuf = buffer.duplicate().readerIndex(propertiesLocation);
                properties.decode(byteBuf, coreMessageObjectPools == null ? 
null : coreMessageObjectPools.getPropertiesDecoderPools());
    ```
    This seems a little heavy handed, when could just get current reader and 
writer index before decoding, then set them back after.
    
    ```
                int readerIndex = buffer.readerIndex();
                int writerIndex = buffer.writerIndex();
                final ByteBuf byteBuf = buffer.readerIndex(propertiesLocation);
                properties.decode(byteBuf, coreMessageObjectPools == null ? 
null : coreMessageObjectPools.getPropertiesDecoderPools());
                buffer.setIndex(readerIndex, writerIndex);
    ```
    
    WDYT?


---

Reply via email to